lkml.org 
[lkml]   [2019]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 0/8] recordmcount cleanups
On Wed, 31 Jul 2019 11:24:08 -0700
Matt Helsley <mhelsley@vmware.com> wrote:

> recordmcount presents unnecessary challenges to reviewers:
>
> It pretends to wrap access to the ELF file in
> uread/uwrite/ulseek functions which aren't related
> the way you might think (i.e. not the way read, write,
> and lseek are releated to each other).
>
> It uses setjmp/longjmp to handle errors (and success)
> during processing of the object files. This makes it
> hard to review what functions are doing, how globals
> change over time, etc.
>
> There are some kernel style nits.
>
> This series addresses all of those by removing un-helper functions,
> unused parameters, and rewriting the error/success handling to
> better resemble regular kernel C code.
>

I applied these patches to my queue.

I pushed them to my repo on branch ftrace/core

git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git

But note, that this branch will rebase, probably on top of v5.3-rc3
when it comes out.

-- Steve

\
 
 \ /
  Last update: 2019-08-02 19:47    [W:0.087 / U:3.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site