lkml.org 
[lkml]   [2019]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH] compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use
From
Date
On Fri, 2019-08-02 at 09:09 -0700, Kees Cook wrote:
> On Fri, Aug 02, 2019 at 02:34:18PM +0200, Pavel Machek wrote:
> > I like the "fallthrough". It looks like "return" and it should, no
> > need to have __'s there..
>
> Yeah, it would have the same feel as "break", "continue", "return"...
>
> The only place I see this already used is in net/sctp/sm_make_chunk.c,
> as a label, which would be trivial to adjust...

Yeah.

From the RFC patch:

For allow compilation of a kernel that includes net/sctp, this patch
also requires a rename of the use of fallthrough as a label in
net/sctp/sm_make_chunk.c that was submitted as:

https://lore.kernel.org/lkml/e0dd3af448e38e342c1ac6e7c0c802696eb77fd6.1564549413.git.joe@perches.com/


\
 
 \ /
  Last update: 2019-08-02 18:17    [W:0.078 / U:4.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site