lkml.org 
[lkml]   [2019]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] gpio: mxc: Use devm_clk_get_optional instead of devm_clk_get
czw., 1 sie 2019 o 10:54 <Anson.Huang@nxp.com> napisał(a):
>
> From: Anson Huang <Anson.Huang@nxp.com>
>
> i.MX SoC's GPIO clock is optional, so it is better to use
> devm_clk_get_optional instead of devm_clk_get.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> drivers/gpio/gpio-mxc.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
> index b281358..7907a87 100644
> --- a/drivers/gpio/gpio-mxc.c
> +++ b/drivers/gpio/gpio-mxc.c
> @@ -435,12 +435,9 @@ static int mxc_gpio_probe(struct platform_device *pdev)
> return port->irq;
>
> /* the controller clock is optional */
> - port->clk = devm_clk_get(&pdev->dev, NULL);
> - if (IS_ERR(port->clk)) {
> - if (PTR_ERR(port->clk) == -EPROBE_DEFER)
> - return -EPROBE_DEFER;
> - port->clk = NULL;
> - }
> + port->clk = devm_clk_get_optional(&pdev->dev, NULL);
> + if (IS_ERR(port->clk))
> + return PTR_ERR(port->clk);
>
> err = clk_prepare_enable(port->clk);
> if (err) {
> --
> 2.7.4
>

Patch applied, thanks!

Bart

\
 
 \ /
  Last update: 2019-08-02 09:08    [W:0.081 / U:4.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site