lkml.org 
[lkml]   [2019]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6 1/9] PCI/ERR: Update error status after reset_link()
From
Date
On Thu, 2019-08-15 at 17:16 -0500, Bjorn Helgaas wrote:
> On Fri, Jul 26, 2019 at 02:43:11PM -0700, sathyanarayanan.kuppuswamy@linux.intel.com wrote:
> > From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> >
> > Commit bdb5ac85777d ("PCI/ERR: Handle fatal error recovery") uses
> > reset_link() to recover from fatal errors. But, if the reset is
> > successful there is no need to continue the rest of the error recovery
> > checks. Also, during fatal error recovery, if the initial value of error
> > status is PCI_ERS_RESULT_DISCONNECT or PCI_ERS_RESULT_NO_AER_DRIVER then
> > even after successful recovery (using reset_link()) pcie_do_recovery()
> > will report the recovery result as failure. So update the status of
> > error after reset_link().
[]
> > diff --git a/drivers/pci/pcie/err.c b/drivers/pci/pcie/err.c
[]
> > @@ -204,9 +204,13 @@ void pcie_do_recovery(struct pci_dev *dev, enum pci_channel_state state,
> > else
> > pci_walk_bus(bus, report_normal_detected, &status);
> >
> > - if (state == pci_channel_io_frozen &&
> > - reset_link(dev, service) != PCI_ERS_RESULT_RECOVERED)
> > - goto failed;
> > + if (state == pci_channel_io_frozen) {
> > + status = reset_link(dev, service);
> > + if (status != PCI_ERS_RESULT_RECOVERED)
> > + goto failed;
> > + else
> > + goto done;
>
> This will be easier to read without the negation, i.e.,
>
> if (status == PCI_ERS_RESULT_RECOVERED)
> goto done;
> else
> goto failed;

bikeshed: I think it'd be easier to read without the else

status = reset_link(dev, service);
if (status != PCI_ERS_RESULT_RECOVERED)
goto failed;

goto done;

\
 
 \ /
  Last update: 2019-08-16 03:55    [W:0.060 / U:1.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site