lkml.org 
[lkml]   [2019]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-next: build failure after merge of the security tree
On Mon, Aug 12, 2019 at 02:58:23PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the security tree, today's linux-next build (arm
> multi_v7_defconfig) failed like below.
>
> Caused by commit
>
> 45d29f9e9b8b ("security: Support early LSMs")
>
> I have added the following fix for today:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 12 Aug 2019 14:54:20 +1000
> Subject: [PATCH] early_security_init() needs a stub got !CONFIG_SECURITY
>
> An arm multi_v7_defconfig fails like this:
>
> init/main.c: In function 'start_kernel':
> init/main.c:596:2: error: implicit declaration of function 'early_security_init'; did you mean 'security_init'? [-Werror=implicit-function-declaration]
> early_security_init();
> ^~~~~~~~~~~~~~~~~~~
> security_init
>
> Fixes: 45d29f9e9b8b ("security: Support early LSMs")
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

Acked-by: Kees Cook <keescook@chromium.org>

-Kees

> ---
> include/linux/security.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/include/linux/security.h b/include/linux/security.h
> index 807dc0d24982..23e1c3f17d48 100644
> --- a/include/linux/security.h
> +++ b/include/linux/security.h
> @@ -473,6 +473,11 @@ static inline int security_init(void)
> return 0;
> }
>
> +static inline int early_security_init(void)
> +{
> + return 0;
> +}
> +
> static inline int security_binder_set_context_mgr(struct task_struct *mgr)
> {
> return 0;
> --
> 2.20.1
>
> --
> Cheers,
> Stephen Rothwell



--
Kees Cook

\
 
 \ /
  Last update: 2019-08-12 19:34    [W:0.080 / U:1.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site