lkml.org 
[lkml]   [2019]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/7] drm/amdgpu/mes10.1: Fix header guard
On Thu, Jul 4, 2019 at 7:52 AM Nathan Chancellor
<natechancellor@gmail.com> wrote:
>
> clang warns:
>
> In file included from drivers/gpu/drm/amd/amdgpu/nv.c:53:
> drivers/gpu/drm/amd/amdgpu/../amdgpu/mes_v10_1.h:24:9: warning:
> '__MES_V10_1_H__' is used as a header guard here, followed by #define of
> a different macro [-Wheader-guard]
> #ifndef __MES_V10_1_H__
> ^~~~~~~~~~~~~~~
> drivers/gpu/drm/amd/amdgpu/../amdgpu/mes_v10_1.h:25:9: note:
> '__MES_v10_1_H__' is defined here; did you mean '__MES_V10_1_H__'?
> #define __MES_v10_1_H__
> ^~~~~~~~~~~~~~~
> __MES_V10_1_H__
> 1 warning generated.
>
> Capitalize the V.
>
> Fixes: 886f82aa7a1d ("drm/amdgpu/mes10.1: add ip block mes10.1 (v2)")
> Link: https://github.com/ClangBuiltLinux/linux/issues/582
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>

I ran into the same one now, and saw your version before sending an
identical patch.

Acked-by: Arnd Bergmann <arnd@arndb.de>

\
 
 \ /
  Last update: 2019-07-08 22:24    [W:0.160 / U:3.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site