Messages in this thread |  | | Date | Fri, 5 Jul 2019 07:24:25 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] omap-iommu: no need to check return value of debugfs_create functions |
| |
On Thu, Jul 04, 2019 at 05:35:52PM +0200, Joerg Roedel wrote: > On Thu, Jul 04, 2019 at 04:36:49PM +0200, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > > never do something different based on this. > > > > Cc: Joerg Roedel <joro@8bytes.org> > > Cc: iommu@lists.linux-foundation.org > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > --- > > Warning, not even test-built, but "should" work :) > > It almost did :) > > > + debugfs_create_file("regs", 0400, d, obj, &attrregs_fops); > > + debugfs_create_file("tlb", 0400, d, obj, &attrtlb_fops); > > + debugfs_create_file("pagetable", 0400, d, obj, &attrpagetable_fops); > > The _fops were named without the 'attr' prefix, changed that and it > compiled. Patch is now applied.
Ah, so close :)
Thanks for fixing it up and applying it!
greg k-h
|  |