lkml.org 
[lkml]   [2019]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/4] Add HDMI jack support on RK3288
On Fri, Jul 05, 2019 at 12:26:19PM +0800, Cheng-Yi Chiang wrote:
> This patch series supports HDMI jack reporting on RK3288, which uses
> DRM dw-hdmi driver and hdmi-codec codec driver.
>
> The previous discussion about reporting jack status using hdmi-notifier
> and drm_audio_component is at
>
> https://lore.kernel.org/patchwork/patch/1083027/
>
> The new approach is to use a callback mechanism that is
> specific to hdmi-codec.

I think this looks reasonable. There's the entire question of getting rid
of the platform_device in hdmi_codec an roll our own devices (so that it
all looks a bit cleaner, like e.g. the cec stuff does). But that can also
be done in a follow-up (if you can convince reviewers of that).
-Daniel

> Cheng-Yi Chiang (4):
> ASoC: hdmi-codec: Add an op to set callback function for plug event
> drm: bridge: dw-hdmi: Report connector status using callback
> ASoC: rockchip_max98090: Add dai_link for HDMI
> ASoC: rockchip_max98090: Add HDMI jack support
>
> .../gpu/drm/bridge/synopsys/dw-hdmi-audio.h | 3 +
> .../drm/bridge/synopsys/dw-hdmi-i2s-audio.c | 10 ++
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 32 ++++-
> include/sound/hdmi-codec.h | 16 +++
> sound/soc/codecs/hdmi-codec.c | 52 ++++++++
> sound/soc/rockchip/rockchip_max98090.c | 112 ++++++++++++++----
> 6 files changed, 201 insertions(+), 24 deletions(-)
>
> --
> 2.22.0.410.gd8fdbe21b5-goog
>

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

\
 
 \ /
  Last update: 2019-07-05 10:31    [W:0.111 / U:4.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site