lkml.org 
[lkml]   [2019]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH][next] ubifs: remove redundant assignment to pointer fname
From
Date
Hello!

On 05.07.2019 1:28, Colin King wrote:

> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer fname rc is being assigned with a value that is never

rc?

> read because the function returns after the assignment. The assignment
> is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> fs/ubifs/debug.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c
> index 92fe5c5ed78a..95da71e13fc8 100644
> --- a/fs/ubifs/debug.c
> +++ b/fs/ubifs/debug.c
> @@ -2817,7 +2817,6 @@ void dbg_debugfs_init_fs(struct ubifs_info *c)
> c->vi.ubi_num, c->vi.vol_id);
> if (n == UBIFS_DFS_DIR_LEN) {
> /* The array size is too small */
> - fname = UBIFS_DFS_DIR_NAME;
> return;
> }
>

MBR, Sergei

\
 
 \ /
  Last update: 2019-07-05 10:25    [W:0.061 / U:1.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site