Messages in this thread |  | | Subject | Re: [PATCH v2 3/7] rtc: mt6397: improvements of rtc driver | From | Matthias Brugger <> | Date | Thu, 4 Jul 2019 11:13:51 +0200 |
| |
On 03/07/2019 18:48, Frank Wunderlich wrote: > From: Josef Friedl <josef.friedl@speed.at> > > - use regmap_read_poll_timeout to drop while-loop > - use devm-api to drop remove-callback > - add new compatible for mt6323 >
It's up to the maintainer but I don't like patches doing clean-ups together with adding support for new HW, although it's a trivial one here.
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de> > =2D-- > drivers/rtc/rtc-mt6397.c | 55 ++++++++++++++++------------------------ > 1 file changed, 22 insertions(+), 33 deletions(-) > > diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c > index c08ee5edf865..e5ddf0d0b6f1 100644 > =2D-- a/drivers/rtc/rtc-mt6397.c > +++ b/drivers/rtc/rtc-mt6397.c > @@ -4,16 +4,19 @@ > * Author: Tianping.Fang <tianping.fang@mediatek.com>
Missing in the CC list.
|  |