[lkml]   [2019]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2 3/4] net: dsa: vsc73xx: add support for parallel mode
Hi Pawel,

this looks overall good and the following is just
documentation nit-pick so feel free to add my
Reviewed-by: Linus Walleij <>

On Wed, Jul 3, 2019 at 7:21 PM Pawel Dembicki <> wrote:

> This patch add platform part of vsc73xx driver.
> It allows to use chip connected by parallel interface.
> Signed-off-by: Pawel Dembicki <>

I would elaborate on the fact that we're dealing with memory-mapped
I/O but perhaps even more important to do that in the source code file and
Kconfig so it is close to the users rather than in the changelog.

Write something about the address bus wireing making all
accesses big endian.

> + tristate "Vitesse VSC7385/7388/7395/7398 Platform mode support"
> + depends on HAS_IOMEM
> + ---help---
> + This enables support for the Vitesse VSC7385, VSC7388, VSC7395
> + and VSC7398 SparX integrated ethernet switches in Platform managed mode.

I would insert something about memory-mapped I/O mode
over a CPU-attached address bus.

Linus Walleij

 \ /
  Last update: 2019-07-04 09:16    [W:0.070 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site