lkml.org 
[lkml]   [2019]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:timers/urgent] arm64: compat: vdso: Use legacy syscalls as fallback
    Commit-ID:  33a58980ff3cc5dbf0bb1b325746ac69223eda0b
    Gitweb: https://git.kernel.org/tip/33a58980ff3cc5dbf0bb1b325746ac69223eda0b
    Author: Thomas Gleixner <tglx@linutronix.de>
    AuthorDate: Sun, 28 Jul 2019 15:12:56 +0200
    Committer: Thomas Gleixner <tglx@linutronix.de>
    CommitDate: Wed, 31 Jul 2019 00:09:10 +0200

    arm64: compat: vdso: Use legacy syscalls as fallback

    The generic VDSO implementation uses the Y2038 safe clock_gettime64() and
    clock_getres_time64() syscalls as fallback for 32bit VDSO. This breaks
    seccomp setups because these syscalls might be not (yet) allowed.

    Implement the 32bit variants which use the legacy syscalls and select the
    variant in the core library.

    The 64bit time variants are not removed because they are required for the
    time64 based vdso accessors.

    Fixes: 00b26474c2f1 ("lib/vdso: Provide generic VDSO implementation")
    Reported-by: Sean Christopherson <sean.j.christopherson@intel.com>
    Reported-by: Paul Bolle <pebolle@tiscali.nl>
    Suggested-by: Andy Lutomirski <luto@kernel.org>
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Tested-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
    Reviewed-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
    Link: https://lkml.kernel.org/r/20190728131648.971361611@linutronix.de

    ---
    arch/arm64/include/asm/vdso/compat_gettimeofday.h | 40 +++++++++++++++++++++++
    1 file changed, 40 insertions(+)

    diff --git a/arch/arm64/include/asm/vdso/compat_gettimeofday.h b/arch/arm64/include/asm/vdso/compat_gettimeofday.h
    index f4812777f5c5..c50ee1b7d5cd 100644
    --- a/arch/arm64/include/asm/vdso/compat_gettimeofday.h
    +++ b/arch/arm64/include/asm/vdso/compat_gettimeofday.h
    @@ -16,6 +16,8 @@

    #define VDSO_HAS_CLOCK_GETRES 1

    +#define VDSO_HAS_32BIT_FALLBACK 1
    +
    static __always_inline
    int gettimeofday_fallback(struct __kernel_old_timeval *_tv,
    struct timezone *_tz)
    @@ -51,6 +53,23 @@ long clock_gettime_fallback(clockid_t _clkid, struct __kernel_timespec *_ts)
    return ret;
    }

    +static __always_inline
    +long clock_gettime32_fallback(clockid_t _clkid, struct old_timespec32 *_ts)
    +{
    + register struct old_timespec32 *ts asm("r1") = _ts;
    + register clockid_t clkid asm("r0") = _clkid;
    + register long ret asm ("r0");
    + register long nr asm("r7") = __NR_compat_clock_gettime;
    +
    + asm volatile(
    + " swi #0\n"
    + : "=r" (ret)
    + : "r" (clkid), "r" (ts), "r" (nr)
    + : "memory");
    +
    + return ret;
    +}
    +
    static __always_inline
    int clock_getres_fallback(clockid_t _clkid, struct __kernel_timespec *_ts)
    {
    @@ -72,6 +91,27 @@ int clock_getres_fallback(clockid_t _clkid, struct __kernel_timespec *_ts)
    return ret;
    }

    +static __always_inline
    +int clock_getres32_fallback(clockid_t _clkid, struct old_timespec32 *_ts)
    +{
    + register struct old_timespec32 *ts asm("r1") = _ts;
    + register clockid_t clkid asm("r0") = _clkid;
    + register long ret asm ("r0");
    + register long nr asm("r7") = __NR_compat_clock_getres;
    +
    + /* The checks below are required for ABI consistency with arm */
    + if ((_clkid >= MAX_CLOCKS) && (_ts == NULL))
    + return -EINVAL;
    +
    + asm volatile(
    + " swi #0\n"
    + : "=r" (ret)
    + : "r" (clkid), "r" (ts), "r" (nr)
    + : "memory");
    +
    + return ret;
    +}
    +
    static __always_inline u64 __arch_get_hw_counter(s32 clock_mode)
    {
    u64 res;
    \
     
     \ /
      Last update: 2019-07-31 00:22    [W:2.405 / U:1.784 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site