lkml.org 
[lkml]   [2019]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 09/30] macintosh: Use kmemdup rather than duplicating its implementation
From
Date


Le 03/07/2019 à 15:14, Fuqian Huang a écrit :
> kmemdup is introduced to duplicate a region of memory in a neat way.
> Rather than kmalloc/kzalloc + memset, which the programmer needs to
> write the size twice (sometimes lead to mistakes), kmemdup improves
> readability, leads to smaller code and also reduce the chances of mistakes.
> Suggestion to use kmemdup rather than using kmalloc/kzalloc + memset.

s/memset/memcpy/

>
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
> ---
> drivers/macintosh/adbhid.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/macintosh/adbhid.c b/drivers/macintosh/adbhid.c
> index 75482eeab2c4..5d14bebfb58f 100644
> --- a/drivers/macintosh/adbhid.c
> +++ b/drivers/macintosh/adbhid.c
> @@ -789,7 +789,8 @@ adbhid_input_register(int id, int default_id, int original_handler_id,
>
> switch (default_id) {
> case ADB_KEYBOARD:
> - hid->keycode = kmalloc(sizeof(adb_to_linux_keycodes), GFP_KERNEL);
> + hid->keycode = kmemdup(adb_to_linux_keycodes,
> + sizeof(adb_to_linux_keycodes), GFP_KERNEL);
> if (!hid->keycode) {
> err = -ENOMEM;
> goto fail;
> @@ -797,8 +798,6 @@ adbhid_input_register(int id, int default_id, int original_handler_id,
>
> sprintf(hid->name, "ADB keyboard");
>
> - memcpy(hid->keycode, adb_to_linux_keycodes, sizeof(adb_to_linux_keycodes));
> -
> switch (original_handler_id) {
> default:
> keyboard_type = "<unknown>";
>

\
 
 \ /
  Last update: 2019-07-03 15:20    [W:0.037 / U:45.624 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site