lkml.org 
[lkml]   [2019]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: fs/seq_file: Replace a seq_printf() call by seq_puts() in seq_hex_dump()
From
Date
> Looks good,

Thanks for your feedback.


> but have you checked whether "m" could ever be NULL

I wonder about this enquiry.

This function parameter should be valid as usual.
Thus it should not be a null pointer under ordinary conditions.


> and whether seq_puts() has a check for that ?

These output functions do not provide an explicit sanity check for their first parameter
so far.

Regards,
Markus

\
 
 \ /
  Last update: 2019-07-03 13:02    [W:0.039 / U:29.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site