lkml.org 
[lkml]   [2019]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] NFS: Less function calls in show_pnfs()


On Tue, 2 Jul 2019, Markus Elfring wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 2 Jul 2019 16:30:53 +0200
>
> Reduce function calls for data output into a sequence.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> fs/nfs/super.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/fs/nfs/super.c b/fs/nfs/super.c
> index f88ddac2dcdf..c301cd585b3b 100644
> --- a/fs/nfs/super.c
> +++ b/fs/nfs/super.c
> @@ -749,11 +749,10 @@ static void show_sessions(struct seq_file *m, struct nfs_server *server) {}
> #ifdef CONFIG_NFS_V4_1
> static void show_pnfs(struct seq_file *m, struct nfs_server *server)
> {
> - seq_printf(m, ",pnfs=");
> - if (server->pnfs_curr_ld)
> - seq_printf(m, "%s", server->pnfs_curr_ld->name);
> - else
> - seq_printf(m, "not configured");
> + seq_printf(m, ",pnfs=%s",
> + server->pnfs_curr_ld
> + ? server->pnfs_curr_ld->name
> + : "not configured");

Unreadable.

julia

> }
>
> static void show_implementation_id(struct seq_file *m, struct nfs_server *nfss)
> --
> 2.22.0
>
>

\
 
 \ /
  Last update: 2019-07-03 10:19    [W:0.042 / U:18.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site