lkml.org 
[lkml]   [2019]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] target: iscsi: iscsi_target_tpg: Fix a possible null-pointer dereference in iscsit_tpg_add_network_portal()
From
Date
On Mon, 2019-07-29 at 10:29 +0800, Jia-Ju Bai wrote:
> In iscsit_tpg_add_network_portal(), there is an if statement on line
> 496
> to check whether tpg->tpg_tiqn is NULL:
> if (tpg->tpg_tiqn)
>
> When tpg->tpg_tiqn is NULL, it is used on line 508:
> pr_debug(..., tpg->tpg_tiqn->tiqn, ...);
>
> Thus, a possible null-pointer dereference may occur.
>
> To fix this bug, tpg->tpg_tiqn is checked before being used.
>
> This bug is found by a static analysis tool STCheck written by us.

I don't really think this is helpful. The first question is, is the
implied might be NULL check correct? The tpg_tiqn is always set by a
non-dummy driver and I think network configuration is only done for the
non dummy driver, so I suspect the NULL check is wrong. Secondly even
if the NULL check were correct, I think there's still a need for some
debugging output, so the proposed patch also looks wrong.

James

\
 
 \ /
  Last update: 2019-07-29 17:02    [W:0.081 / U:2.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site