lkml.org 
[lkml]   [2019]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] arm64: KVM: hyp: debug-sr: Mark expected switch fall-through
On Fri, 26 Jul 2019 15:11:05 +0100,
Anders Roxell <anders.roxell@linaro.org> wrote:
>
> On Fri, 26 Jul 2019 at 14:31, Marc Zyngier <marc.zyngier@arm.com> wrote:
> >
> > On Fri, 26 Jul 2019 12:27:10 +0100,
> > Anders Roxell <anders.roxell@linaro.org> wrote:
> > >
> > > When fall-through warnings was enabled by default the following warnings
> > > was starting to show up:
> > >
> > > ../arch/arm64/kvm/hyp/debug-sr.c: In function ‘__debug_save_state’:
> > > ../arch/arm64/kvm/hyp/debug-sr.c:20:19: warning: this statement may fall
> > > through [-Wimplicit-fallthrough=]
> > > case 15: ptr[15] = read_debug(reg, 15); \
> > > ../arch/arm64/kvm/hyp/debug-sr.c:113:2: note: in expansion of macro ‘save_debug’
> > > save_debug(dbg->dbg_bcr, dbgbcr, brps);
> > > ^~~~~~~~~~
> > > ../arch/arm64/kvm/hyp/debug-sr.c:21:2: note: here
> > > case 14: ptr[14] = read_debug(reg, 14); \
> > > ^~~~
> > > ../arch/arm64/kvm/hyp/debug-sr.c:113:2: note: in expansion of macro ‘save_debug’
> > > save_debug(dbg->dbg_bcr, dbgbcr, brps);
> > > ^~~~~~~~~~
> > > ../arch/arm64/kvm/hyp/debug-sr.c:21:19: warning: this statement may fall
> > > through [-Wimplicit-fallthrough=]
> > > case 14: ptr[14] = read_debug(reg, 14); \
> > > ../arch/arm64/kvm/hyp/debug-sr.c:113:2: note: in expansion of macro ‘save_debug’
> > > save_debug(dbg->dbg_bcr, dbgbcr, brps);
> > > ^~~~~~~~~~
> > > ../arch/arm64/kvm/hyp/debug-sr.c:22:2: note: here
> > > case 13: ptr[13] = read_debug(reg, 13); \
> > > ^~~~
> > > ../arch/arm64/kvm/hyp/debug-sr.c:113:2: note: in expansion of macro ‘save_debug’
> > > save_debug(dbg->dbg_bcr, dbgbcr, brps);
> > > ^~~~~~~~~~
> > >
> > > Rework to add a 'break;' where the compiler warned about
> > > fall-through.
> >
> > That's not what this patch does, I'm afraid.
>
> urgh I'm sorry.
> Sending a v2 shortly.

Don't bother, I'll fix it locally.

Thanks,

M.

--
Jazz is not dead, it just smells funny.

\
 
 \ /
  Last update: 2019-07-29 11:50    [W:0.044 / U:11.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site