lkml.org 
[lkml]   [2019]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/2] Input: soc_button_array - Add support for newer surface devices
On Sat, Jul 27, 2019 at 02:01:26PM +0200, Maximilian Luz wrote:
> On 7/27/19 11:14 AM, Dmitry Torokhov wrote:
> > On Sat, Jul 20, 2019 at 05:05:11PM +0200, Maximilian Luz wrote:
> > > -
> > > - error = gpiod_count(dev, NULL);
> > > - if (error < 0) {
> > > - dev_dbg(dev, "no GPIO attached, ignoring...\n");
> > > - return -ENODEV;
> >
> > I do not think we need to move this into individual "check" functions.
> > It is needed in all cases so we should keep it here.
> >
> > How about version below?
>
> Makes sense, looks good to me!

OK, great, applied.

--
Dmitry

\
 
 \ /
  Last update: 2019-07-28 12:02    [W:0.045 / U:19.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site