lkml.org 
[lkml]   [2019]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [UNVERIFIED SENDER] Re: [RFC 1/1] edac: Add a counter parameter for edac_device_handle_ue/ce()
Date


On 7/25/2019 9:36 PM, Mauro Carvalho Chehab wrote:
>> /* Propagate the count up the 'totals' tree */
>> - instance->counters.ue_count++;
>> - edac_dev->counters.ue_count++;
>> + instance->counters.ue_count += error_count;
>> + edac_dev->counters.ue_count += error_count;
> Patch itself looks a good idea, but maybe it should rise a WARN()
> if error_count == 0.
Good point, shouldn't we use WARN_ONCE here? if the user call
edac_device_handle_ue() with error count == 0, it not be change in
run-time, only if the error count parameter is calculated somehow, and
it'll be the *caller* issue that didn't check the error count.
What you think?

>
> That applies for both CE and UE error logic.
Sure.

Thanks,
Hanna
>
> Thanks,
> Mauro

\
 
 \ /
  Last update: 2019-07-28 11:34    [W:0.158 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site