lkml.org 
[lkml]   [2019]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Kbuild: Handle PREEMPT_RT for version string and magic
Masahiro,

On Sun, 28 Jul 2019, Masahiro Yamada wrote:
>
> Since CONFIG_PREEMPTION was introduced after -rc1,
> I think this should be queued on top of -rc2.

Right. Are you picking it up?

> > -#ifdef CONFIG_PREEMPT
> > -#define MODULE_VERMAGIC_PREEMPT "preempt "
> > +#ifdef CONFIG_PREEMPTION
> > +# ifdef CONFIG_PREEMPT
> > +# define MODULE_VERMAGIC_PREEMPT "preempt "
> > +# else
> > +# define MODULE_VERMAGIC_PREEMPT "preempt_rt "
> > +# endif
> > #else
> > -#define MODULE_VERMAGIC_PREEMPT ""
> > +# define MODULE_VERMAGIC_PREEMPT ""
>
> Maybe, is the following more readable?
>
> #if defined(CONFIG_PREEMPT_RT)
> #define MODULE_VERMAGIC_PREEMPT "preempt_rt "
> #elif defined(CONFIG_PREEMPT)
> #define MODULE_VERMAGIC_PREEMPT "preempt "
> #else
> #define MODULE_VERMAGIC_PREEMPT ""
> #endif

Doh. That's obvious. Must be a result of the heat wave we had.
Will send a V2.

Thanks,

tglx

\
 
 \ /
  Last update: 2019-07-28 11:14    [W:0.075 / U:11.852 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site