lkml.org 
[lkml]   [2019]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/3] bcache: use allocator reserves instead of watermarks
From
Date
On 2019/7/27 6:19 下午, Yaowei Bai wrote:
> Commit 78365411b344 ("bcache: Rework allocator reserves") introduced
> allocator reserves and dropped watermarks, let's keep this consistent
> to avoid confusing.
>
> Signed-off-by: Yaowei Bai <baiyaowei@cmss.chinamobile.com>

It is OK to me, I will add it to my for-test.

Thanks.

Coly Li

> ---
> drivers/md/bcache/alloc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/md/bcache/alloc.c b/drivers/md/bcache/alloc.c
> index c22c260..609df38 100644
> --- a/drivers/md/bcache/alloc.c
> +++ b/drivers/md/bcache/alloc.c
> @@ -622,13 +622,13 @@ bool bch_alloc_sectors(struct cache_set *c,
> spin_lock(&c->data_bucket_lock);
>
> while (!(b = pick_data_bucket(c, k, write_point, &alloc.key))) {
> - unsigned int watermark = write_prio
> + unsigned int reserve = write_prio
> ? RESERVE_MOVINGGC
> : RESERVE_NONE;
>
> spin_unlock(&c->data_bucket_lock);
>
> - if (bch_bucket_alloc_set(c, watermark, &alloc.key, 1, wait))
> + if (bch_bucket_alloc_set(c, reserve, &alloc.key, 1, wait))
> return false;
>
> spin_lock(&c->data_bucket_lock);
>

\
 
 \ /
  Last update: 2019-07-27 16:15    [W:0.042 / U:12.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site