Messages in this thread |  | | Subject | Re: [PATCH v3 2/2] Input: soc_button_array - Add support for newer surface devices | From | Maximilian Luz <> | Date | Sat, 27 Jul 2019 14:01:26 +0200 |
| |
On 7/27/19 11:14 AM, Dmitry Torokhov wrote: > On Sat, Jul 20, 2019 at 05:05:11PM +0200, Maximilian Luz wrote: >> - >> - error = gpiod_count(dev, NULL); >> - if (error < 0) { >> - dev_dbg(dev, "no GPIO attached, ignoring...\n"); >> - return -ENODEV; > > I do not think we need to move this into individual "check" functions. > It is needed in all cases so we should keep it here. > > How about version below?
Makes sense, looks good to me!
Maximilian
|  |