lkml.org 
[lkml]   [2019]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: memory leak in vq_meta_prefetch
On Fri, Jul 26, 2019 at 3:00 PM Catalin Marinas <catalin.marinas@arm.com> wrote:
>
> On Wed, Jul 24, 2019 at 12:18:07PM -0700, syzbot wrote:
> > syzbot found the following crash on:
> >
> > HEAD commit: c6dd78fc Merge branch 'x86-urgent-for-linus' of git://git...
> > git tree: upstream
> > console output: https://syzkaller.appspot.com/x/log.txt?x=15fffef4600000
> > kernel config: https://syzkaller.appspot.com/x/.config?x=8de7d700ea5ac607
> > dashboard link: https://syzkaller.appspot.com/bug?extid=a871c1e6ea00685e73d7
> > compiler: gcc (GCC) 9.0.0 20181231 (experimental)
> > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=127b0334600000
> > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=12609e94600000
> >
> > The bug was bisected to:
> >
> > commit 0e5f7d0b39e1f184dc25e3adb580c79e85332167
> > Author: Nicolas Ferre <nicolas.ferre@atmel.com>
> > Date: Wed Mar 16 13:19:49 2016 +0000
> >
> > ARM: dts: at91: shdwc binding: add new shutdown controller documentation
>
> That's another wrong commit identification (a documentation patch should
> not cause a memory leak).
>
> I don't really think kmemleak, with its relatively high rate of false
> positives, is suitable for automated testing like syzbot. You could

Hi Catalin,

Do you mean automated testing in general, or bisection only?
The wrong commit identification is related to bisection only, but you
generalized it to automated testing in general. So which exactly you
mean?


> reduce the false positives if you add support for scanning in
> stop_machine(). Otherwise, in order to avoid locking the kernel for long
> periods, kmemleak runs concurrently with other threads (even on the
> current CPU) and under high load, pointers are missed (e.g. they are in
> CPU registers rather than stack).

\
 
 \ /
  Last update: 2019-07-26 17:22    [W:0.053 / U:6.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site