Messages in this thread |  | | Subject | Re: [PATCH] net: rds: Fix possible null-pointer dereferences in rds_rdma_cm_event_handler_cmn() | From | santosh.shilimkar@oracle ... | Date | Fri, 26 Jul 2019 07:24:31 -0700 |
| |
On 7/26/19 7:17 AM, Jia-Ju Bai wrote: > In rds_rdma_cm_event_handler_cmn(), there are some if statements to > check whether conn is NULL, such as on lines 65, 96 and 112. > But conn is not checked before being used on line 108: > trans->cm_connect_complete(conn, event); > and on lines 140-143: > rdsdebug("DISCONNECT event - dropping connection " > "%pI6c->%pI6c\n", &conn->c_laddr, > &conn->c_faddr); > rds_conn_drop(conn); > > Thus, possible null-pointer dereferences may occur. > > To fix these bugs, conn is checked before being used. > > These bugs are found by a static analysis tool STCheck written by us. > > Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com> > --- That's possible. Looks good.
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
|  |