lkml.org 
[lkml]   [2019]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [PATCH] staging: iio: ad2s1210: Use device-managed API
Date
On Fri, 2019-07-26 at 19:07 +0800, Chuhong Yuan wrote:
> [External]
>
> Use device-managed API to simplify the code.
> The remove function is redundant now and can
> be deleted.

Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>

>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
> drivers/staging/iio/resolver/ad2s1210.c | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c
> index 0c1bd108c386..4b25a3a314ed 100644
> --- a/drivers/staging/iio/resolver/ad2s1210.c
> +++ b/drivers/staging/iio/resolver/ad2s1210.c
> @@ -671,7 +671,7 @@ static int ad2s1210_probe(struct spi_device *spi)
> indio_dev->num_channels = ARRAY_SIZE(ad2s1210_channels);
> indio_dev->name = spi_get_device_id(spi)->name;
>
> - ret = iio_device_register(indio_dev);
> + ret = devm_iio_device_register(&spi->dev, indio_dev);
> if (ret)
> return ret;
>
> @@ -683,15 +683,6 @@ static int ad2s1210_probe(struct spi_device *spi)
> return 0;
> }
>
> -static int ad2s1210_remove(struct spi_device *spi)
> -{
> - struct iio_dev *indio_dev = spi_get_drvdata(spi);
> -
> - iio_device_unregister(indio_dev);
> -
> - return 0;
> -}
> -
> static const struct of_device_id ad2s1210_of_match[] = {
> { .compatible = "adi,ad2s1210", },
> { }
> @@ -710,7 +701,6 @@ static struct spi_driver ad2s1210_driver = {
> .of_match_table = of_match_ptr(ad2s1210_of_match),
> },
> .probe = ad2s1210_probe,
> - .remove = ad2s1210_remove,
> .id_table = ad2s1210_id,
> };
> module_spi_driver(ad2s1210_driver);
\
 
 \ /
  Last update: 2019-07-26 14:37    [W:0.034 / U:5.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site