lkml.org 
[lkml]   [2019]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] ALSA: i2c: ak4xxx-adda: Fix a possible null pointer dereference in build_adc_controls()
On Fri, 26 Jul 2019 04:14:42 +0200,
Jia-Ju Bai wrote:
>
> In build_adc_controls(), there is an if statement on line 773 to check
> whether ak->adc_info is NULL:
> if (! ak->adc_info ||
> ! ak->adc_info[mixer_ch].switch_name)
>
> When ak->adc_info is NULL, it is used on line 792:
> knew.name = ak->adc_info[mixer_ch].selector_name;
>
> Thus, a possible null-pointer dereference may occur.
>
> To fix this bug, referring to lines 773 and 774, ak->adc_info
> and ak->adc_info[mixer_ch].selector_name are checked before being used.
>
> This bug is found by a static analysis tool STCheck written by us.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>

Applied, thanks.


Takashi

\
 
 \ /
  Last update: 2019-07-26 14:27    [W:0.027 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site