lkml.org 
[lkml]   [2019]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 1/2] extcon: axp288: Add missed error check
On Fri, Jul 26, 2019 at 10:15:30AM +0900, Chanwoo Choi wrote:
> On 19. 7. 26. 오전 5:34, Andy Shevchenko wrote:
> > It seems from the very beginning the error check has been missed
> > in axp288_extcon_log_rsi(). Add it here.

> > ret = regmap_read(info->regmap, AXP288_PS_BOOT_REASON_REG, &val);
> > + if (ret < 0)
> > + return;
>
> It need to print error log because axp288_extcon_log_rsi() has the void'
> return type if there is no any error log, it is not possible to check
> the error status.

Makes sense.
Will add in v2.

P.S. You answered privately, I had returned Cc list back.

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2019-07-26 14:13    [W:0.045 / U:47.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site