lkml.org 
[lkml]   [2019]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH 24/40] soundwire: cadence_master: use BIOS defaults for frame shape
From
Date
On 2019-07-26 01:40, Pierre-Louis Bossart wrote:
> +static u32 cdns_set_default_frame_shape(int n_rows, int n_cols)
> +{
> + u32 val;
> + int c;
> + int r;
> +
> + r = sdw_find_row_index(n_rows);
> + c = sdw_find_col_index(n_cols);
> +
> + val = (r << 3) | c;
> +
> + return val;
> +}
> +
> /**
> * sdw_cdns_init() - Cadence initialization
> * @cdns: Cadence instance
> @@ -977,7 +990,9 @@ int sdw_cdns_init(struct sdw_cdns *cdns)
> cdns_writel(cdns, CDNS_MCP_CLK_CTRL0, val);
>
> /* Set the default frame shape */
> - cdns_writel(cdns, CDNS_MCP_FRAME_SHAPE_INIT, CDNS_DEFAULT_FRAME_SHAPE);
> + val = cdns_set_default_frame_shape(prop->default_row,
> + prop->default_col);
> + cdns_writel(cdns, CDNS_MCP_FRAME_SHAPE_INIT, val);
>
> /* Set SSP interval to default value */
> cdns_writel(cdns, CDNS_MCP_SSP_CTRL0, CDNS_DEFAULT_SSP_INTERVAL);
>

Suggestion:
declare "generic" _get_frame_frame(rows, cols) instead and let it do the
bitwise operations for you. Pretty sure this won't be the only place in
code where reg value for frame_shape needs to be prepared.

Said function could be as simple as:
return (row << 3) | cols;
+inline flag

i.e. could be even a macro..

Otherwise modify _set_default_frame_shape to simply:
return (r << 3) | c

without involving additional local val variable (I don't really see the
point for any locals there though).

\
 
 \ /
  Last update: 2019-07-26 12:21    [W:0.611 / U:14.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site