lkml.org 
[lkml]   [2019]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] RISC-V: Support case insensitive ISA string parsing.
On Fri, 26 Jul 2019, Atish Patra wrote:

> On 7/26/19 1:47 PM, Paul Walmsley wrote:
> > On Fri, 26 Jul 2019, Atish Patra wrote:
> >
> > > As per riscv specification, ISA naming strings are
> > > case insensitive. However, currently only lower case
> > > strings are parsed during cpu procfs.
> > >
> > > Support parsing of upper case letters as well.
> > >
> > > Signed-off-by: Atish Patra <atish.patra@wdc.com>
> >
> > Is there a use case that's driving this, or
>
> Currently, we use all lower case isa string in kvmtool. But somebody can have
> uppercase letters in future as spec allows it.
>
>
> can we just say, "use
> > lowercase letters" and leave it at that?
> >
>
> In that case, it will not comply with RISC-V spec. Is that okay ?

I think that section of the specification is mostly concerned with someone
trying to define "f" as a different extension than "F", or something like
that. I'm not sure that it imposes any constraint that software must
accept both upper and lower case ISA strings.

What gives me pause here is that this winds up impacting DT schema
validation:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/riscv/cpus.yaml#n41



- Paul

\
 
 \ /
  Last update: 2019-07-27 01:30    [W:0.062 / U:2.880 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site