lkml.org 
[lkml]   [2019]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH V2 net-next 07/11] net: hns3: adds debug messages to identify eth down cause
From
Date
On Fri, 2019-07-26 at 22:00 +0000, Saeed Mahameed wrote:
> On Fri, 2019-07-26 at 11:24 +0800, Huazhong Tan wrote:
> > From: Yonglong Liu <liuyonglong@huawei.com>
> >
> > Some times just see the eth interface have been down/up via
> > dmesg, but can not know why the eth down. So adds some debug
> > messages to identify the cause for this.
[]
> > diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> []
> > @@ -459,6 +459,10 @@ static int hns3_nic_net_open(struct net_device
> > *netdev)
> > h->ae_algo->ops->set_timer_task(priv->ae_handle, true);
> >
> > hns3_config_xps(priv);
> > +
> > + if (netif_msg_drv(h))
> > + netdev_info(netdev, "net open\n");
> > +
>
> to make sure this is only intended for debug, and to avoid repetition.
> #define hns3_dbg(__dev, format, args...) \
> ({ \
> if (netif_msg_drv(h)) \
> netdev_info(h->netdev, format, ##args); \
> })

netif_dbg(h, drv, h->netdev, "net open\n")


\
 
 \ /
  Last update: 2019-07-27 00:19    [W:0.045 / U:4.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site