lkml.org 
[lkml]   [2019]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [patch] perf report segfault with 0-sized strings
Em Thu, Jul 25, 2019 at 03:04:32PM -0400, Vince Weaver escreveu:
>
> probably all perf_header_strings are affected by this. The fuzzer just
> tripped up cmdline now, which needs this fix.

I think we have to catch this earlier, i.e. when processing each
feature, lemme check...

- Arnaldo

> Signed-off-by: Vince Weaver <vincent.weaver@maine.edu>
>
> diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
> index c24db7f4909c..631aa1911f3a 100644
> --- a/tools/perf/util/header.c
> +++ b/tools/perf/util/header.c
> @@ -1427,6 +1430,8 @@ static void print_cmdline(struct feat_fd *ff, FILE *fp)
>
> fprintf(fp, "# cmdline : ");
>
> + if (ff->ph->env.cmdline_argv==NULL) return;
> +
> for (i = 0; i < nr; i++) {
> char *argv_i = strdup(ff->ph->env.cmdline_argv[i]);
> if (!argv_i) {

--

- Arnaldo

\
 
 \ /
  Last update: 2019-07-26 21:11    [W:0.050 / U:2.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site