Messages in this thread |  | | Subject | Re: [RFC PATCH 15/17] ipmi: kcs: aspeed: Implement v2 bindings | From | "Wang, Haiyue" <> | Date | Sat, 27 Jul 2019 01:30:24 +0800 |
| |
在 2019-07-26 13:39, Andrew Jeffery 写道: > The v2 bindings allow us to extract the resources from the devicetree. > The table in the driver is retained to derive the channel index, which > removes the need for kcs_chan property from the v1 bindings. The v2 > bindings allow us to reduce the number of warnings generated by the > existing devicetree nodes. > > Cc: Haiyue Wang<haiyue.wang@linux.intel.com> > Cc: Corey Minyard<minyard@acm.org> > Cc: Arnd Bergmann<arnd@arndb.de> > Cc: Greg Kroah-Hartman<gregkh@linuxfoundation.org> > Cc:openipmi-developer@lists.sourceforge.net > Signed-off-by: Andrew Jeffery<andrew@aj.id.au> > --- > drivers/char/ipmi/kcs_bmc_aspeed.c | 156 +++++++++++++++++++++++------ > 1 file changed, 127 insertions(+), 29 deletions(-)
Looks good, thanks for the hard work, the code is more clean! :)
Reviewed-by: Haiyue Wang <haiyue.wang@linux.intel.com>
|  |