lkml.org 
[lkml]   [2019]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1] md: Convert to use int_pow()
On Tue, Jul 23, 2019 at 11:41:55PM +0300, Andy Shevchenko wrote:
> Instead of linear approach to calculate power of 10, use generic int_pow()
> which does it better.

I took into Cc drivers/dm guys as they might have known something about md raid
state of affairs. Sorry if I mistakenly added somebody.

Who is doing this?
Should it be orphaned?

(I got a bounce from Shaohua address)

>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/md/md.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 24638ccedce4..3f1252440ad0 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -3664,11 +3664,7 @@ int strict_strtoul_scaled(const char *cp, unsigned long *res, int scale)
> return -EINVAL;
> if (decimals < 0)
> decimals = 0;
> - while (decimals < scale) {
> - result *= 10;
> - decimals ++;
> - }
> - *res = result;
> + *res = result * int_pow(10, scale - decimals);
> return 0;
> }
>
> --
> 2.20.1
>

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2019-07-26 18:49    [W:0.044 / U:50.740 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site