[lkml]   [2019]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v3 08/13] recordmcount: Clarify what cleanup() does
On Wed, 24 Jul 2019 14:05:02 -0700
Matt Helsley <> wrote:

> cleanup() mostly frees/unmaps the malloc'd/privately-mapped
> copy of the ELF file recordmcount is working on, which is
> set up in mmap_file(). It also deals with positioning within
> the pseduo prive-mapping of the file and appending to the ELF
> file.
> Split into two steps:
> mmap_cleanup() for the mapping itself
> file_append_cleanup() for allocations storing the
> appended ELF data.
> Also, move the global variable initializations out of the main,
> per-object-file loop and nearer to the alloc/init (mmap_file())
> and two cleanup functions so we can more clearly see how they're
> related.
> Signed-off-by: Matt Helsley <>
> ---

Hi Matt,

I reviewed up to this patch and they look fine. I may pull these in as
I don't need a review form Josh for these patches.


-- Steve

 \ /
  Last update: 2019-07-26 18:11    [W:0.137 / U:17.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site