Messages in this thread |  | | From | Paul Burton <> | Subject | Re: [PATCH 02/11] MIPS: qi_lb60: Migrate to devicetree | Date | Thu, 25 Jul 2019 23:47:37 +0000 |
| |
Hi Paul,
On Thu, Jul 25, 2019 at 06:02:06PM -0400, Paul Cercueil wrote: > Move all the platform data to devicetree.
Nice! :)
> The only bit dropped is the PWM beeper, which requires the PWM driver > to be updated. I figured it's okay to remove it here since it's really > a non-critical device, and it'll be re-introduced soon enough.
OK, I can see that being a price worth paying. Though it's possible to include the binding at least for that in this series I'd be even happier. Actually I see we already have
Documentation/devicetree/bindings/pwm/ingenic,jz47xx-pwm.txt
in mainline - what needs to change with it?
> + spi { > + compatible = "spi-gpio"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + sck-gpios = <&gpc 23 GPIO_ACTIVE_HIGH>; > + mosi-gpios = <&gpc 22 GPIO_ACTIVE_HIGH>; > + cs-gpios = <&gpc 21 GPIO_ACTIVE_LOW>; > + num-chipselects = <1>; > + > + spi@0 { > + compatible = "ili8960";
Should this be "ilitek,ili8960"?
Is there a binding & driver for this submitted somewhere? If not then do we need this at all? It doesn't look like the existing platform data would actually lead to a driver being loaded so I'm wondering if we can just drop this until such a driver (or at least a documented DT binding) exists.
Thanks, Paul
|  |