lkml.org 
[lkml]   [2019]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH v1 00/11] perf: Fix errors detected by Smatch
Date
When I used static checker Smatch for perf building, the main target is
to check if there have any potential issues in Arm cs-etm code. So
finally I get many reporting for errors/warnings.

I used below command for using static checker with perf building:

# make VF=1 CORESIGHT=1 -C tools/perf/ \
CHECK="/root/Work/smatch/smatch --full-path" \
CC=/root/Work/smatch/cgcc | tee smatch_reports.txt

I reviewed the errors one by one, if I understood some of these errors
so changed the code as I can, this patch set is the working result; but
still leave some errors due to I don't know what's the best way to fix
it. There also have many inconsistent indenting warnings. So I firstly
send out this patch set and let's see what's the feedback from public
reviewing.

Leo Yan (11):
perf report: Smatch: Fix potential NULL pointer dereference
perf stat: Smatch: Fix use-after-freed pointer
perf top: Smatch: Fix potential NULL pointer dereference
perf annotate: Smatch: Fix dereferencing freed memory
perf trace: Smatch: Fix potential NULL pointer dereference
perf hists: Smatch: Fix potential NULL pointer dereference
perf map: Smatch: Fix potential NULL pointer dereference
perf session: Smatch: Fix potential NULL pointer dereference
perf intel-bts: Smatch: Fix potential NULL pointer dereference
perf intel-pt: Smatch: Fix potential NULL pointer dereference
perf cs-etm: Smatch: Fix potential NULL pointer dereference

tools/perf/builtin-report.c | 4 ++--
tools/perf/builtin-stat.c | 2 +-
tools/perf/builtin-top.c | 8 ++++++--
tools/perf/builtin-trace.c | 5 +++--
tools/perf/ui/browsers/hists.c | 13 +++++++++----
tools/perf/util/annotate.c | 6 ++----
tools/perf/util/cs-etm.c | 2 +-
tools/perf/util/intel-bts.c | 5 ++---
tools/perf/util/intel-pt.c | 5 ++---
tools/perf/util/map.c | 7 +++++--
tools/perf/util/session.c | 3 +++
11 files changed, 36 insertions(+), 24 deletions(-)

--
2.17.1

\
 
 \ /
  Last update: 2019-07-02 12:35    [W:0.151 / U:3.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site