lkml.org 
[lkml]   [2019]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH 0/2] Fixes for sub-section hotplug
Date
Hi all,

these two patches address a couple of issues I found while working on my
vmemmap-patchset.
The issues are:

1) section_deactivate mistakenly zeroes ms->section_mem_map and then
tries to check whether the section is an early section, but since
section_mem_map might have been zeroed, we will return false
when it is really an early section.
In order to fix this, let us check whether the section is early
at function entry, so we do not neet check it again later.

2) shrink_{node,zone}_span work on sub-section granularity now.
The problem is that deactivation of the section occurs later on
in sparse_remove_section, so the pfn_valid()->pfn_section_valid()
check will always return true.
The user visible effect of this is that we are always left with,
at least, PAGES_PER_SECTION spanned, even if we got to remove all
memory linked to a zone.
In order to fix this, decouple section_deactivate() from
sparse_remove_section, and let __remove_section first call
section_deactivate(), so then __remove_zone()->shrink_{zone,node}
will find the right information.

Actually, both patches could be merged in one, but I went this way to make it
more smooth.

Once this have been merged (unless there is a major controvery), I plan to send
out a patch refactoring shrink_{node,zone}_span, since right now it is a bit
messy.

Oscar Salvador (2):
mm,sparse: Fix deactivate_section for early sections
mm,memory_hotplug: Fix shrink_{zone,node}_span

include/linux/memory_hotplug.h | 7 ++--
mm/memory_hotplug.c | 6 +++-
mm/sparse.c | 76 +++++++++++++++++++++++++++++-------------
3 files changed, 62 insertions(+), 27 deletions(-)

--
2.12.3

\
 
 \ /
  Last update: 2019-07-15 10:16    [W:0.103 / U:7.940 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site