lkml.org 
[lkml]   [2019]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 04/22] x86/kvm: Don't call kvm_spurious_fault() from .fixup
From
Date
On 15/07/19 14:40, Josh Poimboeuf wrote:
>>> * Hardware virtualization extension instructions may fault if a
>>> * reboot turns off virtualization while processes are running.
>>> - * Trap the fault and ignore the instruction if that happens.
>>> + * If that happens, trap the fault and panic (unless we're rebooting).
>> Not sure the comment is better than before, but apar from that
> The previous comment didn't seem to match the code, since we only ignore
> the instruction if we're rebooting.
>

"If that happens" refers to "a reboot turns off virtualization while
processes are running". Perhaps

* Usually after catching the fault we just panic; during reboot
* instead the instruction is ignored.

Paolo

\
 
 \ /
  Last update: 2019-07-15 15:06    [W:0.091 / U:8.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site