lkml.org 
[lkml]   [2019]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] platform/x86/pcengines-apuv2: add legacy leds gpio definitions
On 2019-07-08 21:42, Enrico Weigelt, metux IT consult wrote:
> On 04.07.19 11:02, Florian Eckert wrote:
>> Extend the apu2_leds definition to make the leds exportable via the
>> legacy gpio subsystem.
>
> What for ? The gpios are bound to LED devices as that's exactly what
> they are: LEDs.

I have back ported your pcengines-apuv2 device and gpio-amd-fch GPIO
driver to the kernel version 4.19 on OpenWrt.
If I compile and load this without the change no LEDs are visible in
"/sys/class/leds"!

From my point of view the connection between the GPIO and the LEDs
subsystem is missing.
How should the LED subsystem know which GPIO to use?
If I add the change to the pcengines-apuv2 device then the LEDs will be
visilbe under "/sys/class/leds"
and could be used, by OpenWrt userland.

Mybe I miss something.

\
 
 \ /
  Last update: 2019-07-10 14:04    [W:0.068 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site