[lkml]   [2019]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC next v1 3/5] net: stmmac: use GPIO descriptors in stmmac_mdio_reset
On Sun, Jun 9, 2019 at 8:06 PM Martin Blumenstingl
<> wrote:

> Switch stmmac_mdio_reset to use GPIO descriptors. GPIO core handles the
> "snps,reset-gpio" for GPIO descriptors so we don't need to take care of
> it inside the driver anymore.
> The advantage of this is that we now preserve the GPIO flags which are
> passed via devicetree. This is required on some newer Amlogic boards
> which use an Open Drain pin for the reset GPIO. This pin can only output
> a LOW signal or switch to input mode but it cannot output a HIGH signal.
> There are already devicetree bindings for these special cases and GPIO
> core already takes care of them but only if we use GPIO descriptors
> instead of GPIO numbers.
> Signed-off-by: Martin Blumenstingl <>

This is in line with how I want the gpiolib to just swallow all quirks,
Reviewed-by: Linus Walleij <>

Linus Walleij

 \ /
  Last update: 2019-06-09 23:51    [W:0.181 / U:1.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site