lkml.org 
[lkml]   [2019]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 10/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone
On Sat, Jun 29, 2019 at 04:07:51PM +0530, Hariprasad Kelam wrote:

Hello Hari Prasad,
Please add the recommended reviewers mentioned in the TODO file of
rtl8723bs directory.

I see the following emails in the TODO file.

Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hans de Goede <hdegoede@redhat.com> and Larry Finger
<Larry.Finger@lwfinger.net>

> fix below issues reported by checkpatch
>
> CHECK: Using comparison to false is error prone
> CHECK: Using comparison to true is error prone
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
> ---
> drivers/staging/rtl8723bs/hal/hal_btcoex.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> index 66caf34..99e0b91 100644
> --- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> +++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> @@ -290,7 +290,7 @@ static u8 halbtcoutsrc_IsWifiBusy(struct adapter *padapter)
> if (check_fwstate(pmlmepriv, WIFI_ASOC_STATE) == true) {
> if (check_fwstate(pmlmepriv, WIFI_AP_STATE) == true)
> return true;
> - if (true == pmlmepriv->LinkDetectInfo.bBusyTraffic)
> + if (pmlmepriv->LinkDetectInfo.bBusyTraffic)
> return true;
> }
>
> @@ -310,12 +310,12 @@ static u32 _halbtcoutsrc_GetWifiLinkStatus(struct adapter *padapter)
>
> if (check_fwstate(pmlmepriv, WIFI_ASOC_STATE) == true) {
> if (check_fwstate(pmlmepriv, WIFI_AP_STATE) == true) {
> - if (true == bp2p)
> + if (bp2p)
> portConnectedStatus |= WIFI_P2P_GO_CONNECTED;
> else
> portConnectedStatus |= WIFI_AP_CONNECTED;
> } else {
> - if (true == bp2p)
> + if (bp2p)
> portConnectedStatus |= WIFI_P2P_GC_CONNECTED;
> else
> portConnectedStatus |= WIFI_STA_CONNECTED;
> @@ -372,7 +372,7 @@ static u8 halbtcoutsrc_GetWifiScanAPNum(struct adapter *padapter)
>
> pmlmeext = &padapter->mlmeextpriv;
>
> - if (GLBtcWiFiInScanState == false) {
> + if (!GLBtcWiFiInScanState) {
> if (pmlmeext->sitesurvey_res.bss_cnt > 0xFF)
> scan_AP_num = 0xFF;
> else
> @@ -1444,7 +1444,7 @@ void hal_btcoex_IQKNotify(struct adapter *padapter, u8 state)
>
> void hal_btcoex_BtInfoNotify(struct adapter *padapter, u8 length, u8 *tmpBuf)
> {
> - if (GLBtcWiFiInIQKState == true)
> + if (GLBtcWiFiInIQKState)
> return;
>
> EXhalbtcoutsrc_BtInfoNotify(&GLBtCoexist, tmpBuf, length);
> --
> 2.7.4
>

\
 
 \ /
  Last update: 2019-06-30 03:30    [W:0.024 / U:1.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site