lkml.org 
[lkml]   [2019]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 0/3] block: sed-opal: add support for shadow MBR done flag and write
e1;5202;0csOn Sat, Jun 29, 2019 at 10:35:30AM -0600, Jens Axboe wrote:
> On 6/29/19 10:28 AM, Scott Bauer wrote:
> > On Sat, Jun 29, 2019 at 10:26:52AM -0600, Jens Axboe wrote:
> >> On 6/29/19 10:19 AM, Scott Bauer wrote:
> >>>
> >>> Hey Jens,
> >>>
> >>> Can you please stage these for 5.3 aswell?
> >>
> >> Yes, looks fine to me. But it conflicts with the psid revert in terms
> >> of ioctl numbering. You fine with me renumbering IOC_OPAL_MBR_DONE to:
> >>
> >> #define IOC_OPAL_MBR_DONE _IOW('p', 233, struct opal_mbr_done)
> >
> > Sorry for the conflict. That's fine. I'll fix up userland tooling.
>
> Renamed 232 -> 233, and 233 -> 234, for the two conflicts. So now we have:
>
> #define IOC_OPAL_PSID_REVERT_TPR _IOW('p', 232, struct opal_key)
> #define IOC_OPAL_MBR_DONE _IOW('p', 233, struct opal_mbr_done)
> #define IOC_OPAL_WRITE_SHADOW_MBR _IOW('p', 234, struct opal_shadow_mbr)

Looks good, thank you for handling this.

\
 
 \ /
  Last update: 2019-06-29 18:38    [W:0.052 / U:3.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site