lkml.org 
[lkml]   [2019]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 0/2] Fix misuse of blk_rq_stats in blk-iolatency
From
Date
Ping?

On 20/06/2019 10:18, Pavel Begunkov wrote:
> Hi,
>
> Josef, thanks for taking a look.
>
>
> Although, there is nothing critical yet -- just a not working / disabled
> optimisation, but changes in stats could sublty break it. E.g. grouping
> @batch and @mean into a union will increase estimated average by several
> orders of magnitude.
>
> Jens, what do you think?
>
>
>
> On 14/06/2019 16:40, Josef Bacik wrote:
>> On Fri, Jun 14, 2019 at 02:44:11PM +0300, Pavel Begunkov (Silence) wrote:
>>> From: Pavel Begunkov <asml.silence@gmail.com>
>>>
>>> There are implicit assumptions about struct blk_rq_stats, which make
>>> it's very easy to misuse. The first patch fixes consequences, and the
>>> second employs type-system to prevent recurrences.
>>>
>>>
>>> Pavel Begunkov (2):
>>> blk-iolatency: Fix zero mean in previous stats
>>> blk-stats: Introduce explicit stat staging buffers
>>>
>>
>> I don't have a problem with this, but it's up to Jens I suppose
>>
>> Acked-by: Josef Bacik <josef@toxicpanda.com>
>>
>> Thanks,
>>
>> Josef
>>
>

--
Yours sincerely,
Pavel Begunkov

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-06-29 17:39    [W:0.211 / U:2.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site