[lkml]   [2019]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: slub: don't panic for memcg kmem cache creation failure
> -       if (flags & SLAB_PANIC)
> - panic("Cannot create slab %s size=%u realsize=%u order=%u offset=%u flags=%lx\n",
> - s->name, s->size, s->size,
> - oo_order(s->oo), s->offset, (unsigned long)flags);

This is wrong. Without SLAB_PANIC people will start to implement error
checking out of habit and add all slightly different error messages.
This simply increases text and rodata size.

If memcg kmem caches creation failure is OK, then SLAB_PANIC should not
be passed.

The fact that SLAB doesn't implement SLAB_PANIC is SLAB bug.

 \ /
  Last update: 2019-06-29 16:06    [W:0.115 / U:2.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site