lkml.org 
[lkml]   [2019]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    SubjectRe: [PATCH v9 4/4] s390: ap: kvm: Enable PQAP/AQIC facility for the guest
    From
    Date


    On 21.05.19 17:34, Pierre Morel wrote:
    > AP Queue Interruption Control (AQIC) facility gives
    > the guest the possibility to control interruption for
    > the Cryptographic Adjunct Processor queues.
    >
    > Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
    > Reviewed-by: Tony Krowiak <akrowiak@linux.ibm.com>
    > ---
    > arch/s390/tools/gen_facilities.c | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/arch/s390/tools/gen_facilities.c b/arch/s390/tools/gen_facilities.c
    > index 61ce5b5..aed14fc 100644
    > --- a/arch/s390/tools/gen_facilities.c
    > +++ b/arch/s390/tools/gen_facilities.c
    > @@ -114,6 +114,7 @@ static struct facility_def facility_defs[] = {
    > .bits = (int[]){
    > 12, /* AP Query Configuration Information */
    > 15, /* AP Facilities Test */
    > + 65, /* AP Queue Interruption Control */
    > 156, /* etoken facility */
    > -1 /* END */
    > }
    >

    I think we should only set stfle.65 if we have the aiv facility (Because we do not
    have a GISA otherwise)

    So something like this instead?

    diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
    index 28ebd64..1501cd6 100644
    --- a/arch/s390/kvm/kvm-s390.c
    +++ b/arch/s390/kvm/kvm-s390.c
    @@ -2461,6 +2461,9 @@ int kvm_arch_init_vm(struct kvm *kvm, unsigned long type)
    set_kvm_facility(kvm->arch.model.fac_list, 147);
    }

    + if (css_general_characteristics.aiv)
    + set_kvm_facility(kvm->arch.model.fac_mask, 65);
    +
    kvm->arch.model.cpuid = kvm_s390_get_initial_cpuid();
    kvm->arch.model.ibc = sclp.ibc & 0x0fff;

    \
     
     \ /
      Last update: 2019-06-25 22:15    [W:2.577 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site