lkml.org 
[lkml]   [2019]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH V2 2/3] clocksource: imx-sysctr: Add of_clk skip option
Date
Hi, Thomas

> On Sun, 23 Jun 2019, Anson.Huang@nxp.com wrote:
>
> Again the short summary could be more informative. Instead of 'Add foo'
> you could say:
>
> .....: Make timer work with platform driver model
>
> That sums up the real meat of the patch. 'Add some option' is pretty
> uninformative.

Makes sense.

>
> > On some i.MX8M platforms, clock driver uses platform driver model and
> > it is NOT ready during timer initialization phase, the clock
> > operations will fail and system counter driver will fail too. As all
> > the i.MX8M platforms' system counter clock are from OSC which is
> > always enabled, so it is no need to enable clock for system counter
> > driver, the ONLY thing is to pass clock frequence to driver.
> >
> > This patch adds an option of skipping of_clk operation for system
> > counter driver, an optional property "clock-frequency"
> > is introduced to pass the frequency value to system counter driver and
> > indicate driver to skip of_clk operations.
>
> The comments to the changelog of patch 1 apply here as well :)
>
> Hint: 'This patch'

Oops...did NOT notice that, I will resend the V2 patch series as they are actually
similar issues.

Thanks,
Anson

>
> Thanks,
>
> tglx
>

\
 
 \ /
  Last update: 2019-06-23 14:24    [W:0.053 / U:3.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site