lkml.org 
[lkml]   [2019]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH -next] platform/chrome: wilco_ec: Use kmemdup in enqueue_events()
Thanks Yue, looks good to me.

Nick

On Fri, Jun 21, 2019 at 7:59 AM YueHaibing <yuehaibing@huawei.com> wrote:
>
> Use kmemdup rather than duplicating its implementation
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/platform/chrome/wilco_ec/event.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/platform/chrome/wilco_ec/event.c b/drivers/platform/chrome/wilco_ec/event.c
> index c975b76e6255..70156e75047e 100644
> --- a/drivers/platform/chrome/wilco_ec/event.c
> +++ b/drivers/platform/chrome/wilco_ec/event.c
> @@ -248,10 +248,9 @@ static int enqueue_events(struct acpi_device *adev, const u8 *buf, u32 length)
> offset += event_size;
>
> /* Copy event into the queue */
> - queue_event = kzalloc(event_size, GFP_KERNEL);
> + queue_event = kmemdup(event, event_size, GFP_KERNEL);
> if (!queue_event)
> return -ENOMEM;
> - memcpy(queue_event, event, event_size);
> event_queue_push(dev_data->events, queue_event);
> }
>
>
>

\
 
 \ /
  Last update: 2019-06-21 16:51    [W:0.093 / U:0.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site