lkml.org 
[lkml]   [2019]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 02/16] mm: simplify gup_fast_permitted
On Tue, Jun 11, 2019 at 04:40:48PM +0200, Christoph Hellwig wrote:
> Pass in the already calculated end value instead of recomputing it, and
> leave the end > start check in the callers instead of duplicating them
> in the arch code.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> arch/s390/include/asm/pgtable.h | 8 +-------
> arch/x86/include/asm/pgtable_64.h | 8 +-------
> mm/gup.c | 17 +++++++----------
> 3 files changed, 9 insertions(+), 24 deletions(-)

Much cleaner

Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>

Jason

\
 
 \ /
  Last update: 2019-06-21 15:41    [W:0.173 / U:1.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site