[lkml]   [2019]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [EXT] Re: [PATCH v2 1/2] dt-bindings: display: panel: Add support for Raydium RM67191 panel
On Mi, 2019-06-19 at 10:21 -0300, Fabio Estevam wrote:
> Caution: EXT Email
> Hi Robert,
> On Tue, Jun 18, 2019 at 10:33 AM Robert Chiras <
> > wrote:
> >
> > +Optional properties:
> > +- reset-gpios:         a GPIO spec for the RST_B GPIO pin
> > +- pinctrl-0            phandle to the pin settings for the reset
> > pin
> > +- width-mm:            physical panel width [mm]
> > +- height-mm:           physical panel height [mm]
> > +- display-timings:     timings for the connected panel according
> > to [1]
> Still not convinced we need the 'display-timings' property, even as
> an
> optional property. My understanding is that passing display timings
> in
> the devicetree is not encouraged.
> Last time you said you need to pass ''display-timings' to workaround
> the problem of connecting this panel to mx8m DCSS or eLCDIF.
> The panel timings come from the LCD manufacturer and it is agnostic
> to
> what display controller interface it is connected to.
> So I suggest making sure the timings passed in the driver are correct
> as per the vendor datasheet. If they are correct and one specific
> interface is not able to drive it, then probably it is a bug in this
> specific display controller interface or in the SoC clock driver.

I understand. I will remove the display-timings from dt and also from
driver. Currently, this panel works in this form with both LCDIF and
DCSS on our 8M SoC so, as you said, probably the issue we were seeing
in our tree was coming from elsewhere.
 \ /
  Last update: 2019-06-20 09:59    [W:0.049 / U:19.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site