[lkml]   [2019]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2] mei: no need to check return value of debugfs_create functions
On Wed, Jun 19, 2019 at 08:25:58AM +0000, Winkler, Tomas wrote:
> >
> > When calling debugfs functions, there is no need to ever check the return
> > value. The function can work or not, but the code logic should never do
> > something different based on this.
> Maybe need to mention that API has changed in patch ' ff9fb72bc07705c00795ca48631f7fffe24d2c6b' in 5.0
> and create_dir() doesn't return NULL but ERR_PTR() and proper checking is done inside the debugfs functions.
> Not sure how critical is that but, but this should go probably to stable 5.0+ as well.

It's not critical at all, the odds of an error ever returning, or NULL,
from debugfs before is just as rare as it is today :)

> Ack otherwise.

great, thanks for reviewing it.

greg k-h

 \ /
  Last update: 2019-06-19 15:01    [W:0.034 / U:25.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site